Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(analytics): skip ListDomains if user cannot manage domains and have only one loading message #6624

Merged
merged 1 commit into from
Dec 3, 2022
Merged

fix(analytics): skip ListDomains if user cannot manage domains and have only one loading message #6624

merged 1 commit into from
Dec 3, 2022

Conversation

aditya-radhakrishnan
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan commented Dec 3, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Dec 3, 2022
@github-actions
Copy link

github-actions bot commented Dec 3, 2022

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 42s ⏱️ -14s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit b122da9. ± Comparison against base commit 99e6f3a.

@aditya-radhakrishnan aditya-radhakrishnan merged commit 5e971ce into datahub-project:master Dec 3, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@aditya-radhakrishnan @cccs-Dustin
fix(analytics): skip ListDomains if user cannot manage domains and ha…
3b06a16 
…ve only one loading message (datahub-project#6624)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aditya-radhakrishnan @jjoyce0510