Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/powerbi-report-server): deprecate unused graphql config #6630

Merged
merged 1 commit into from
Dec 7, 2022
Merged

fix(ingest/powerbi-report-server): deprecate unused graphql config #6630

merged 1 commit into from
Dec 7, 2022

Conversation

daha
Copy link
Contributor

@daha daha commented Dec 4, 2022

The source use graph from ctx so graphql_url is not needed.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata labels Dec 4, 2022
@github-actions
Copy link

github-actions bot commented Dec 4, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 1m 12s ⏱️
   766 tests    764 ✔️ 2 💤 0 ❌
1 534 runs  1 529 ✔️ 5 💤 0 ❌

Results for commit 8eda2a1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 4, 2022 •
edited
Loading

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 45s ⏱️ -2s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 8eda2a1. ± Comparison against base commit 4876fdd.

♻️ This comment has been updated with latest results.

@daha
fix: deprecate unused config in powerbi-report-server source
8eda2a1 
The source use graph from ctx so graphql_url is not needed.
@daha daha force-pushed the deprecate-unused-graphql_url branch from a7522da to 8eda2a1 Compare December 4, 2022 14:17
@anshbansal anshbansal added the community-contribution PR or Issue raised by member(s) of DataHub Community label Dec 6, 2022
@hsheth2 hsheth2 changed the title fix: deprecate unused config in powerbi-report-server source fix(ingest/powerbi-report-server): deprecate unused graphql config Dec 7, 2022
@hsheth2 hsheth2 merged commit 1a66770 into datahub-project:master Dec 7, 2022
@daha daha deleted the deprecate-unused-graphql_url branch December 9, 2022 21:23
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@daha @cccs-Dustin
fix(ingest/powerbi-report-server): deprecate unused graphql config (d…
506e050 
…atahub-project#6630)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daha @hsheth2 @anshbansal