feat(gms): Pluggable Authentication & Authorization Framework #6634

siddiquebagwan · 2022-12-05T06:17:54Z

No description provided.

…:acryldata/datahub-fork into master+acr-3593-pluggable-auth-framework

github-actions · 2022-12-05T06:50:53Z

Unit Test Results (build & test)

633 tests +11 629 ✔️ +11 15m 46s ⏱️ +7s
162 suites +  4     4 💤 ±  0
162 files +  4     0 ❌ ±  0

Results for commit 6665d53. ± Comparison against base commit 43c566e.

This pull request removes 4 and adds 15 tests. Note that renamed tests count towards both.

com.datahub.authorization.ranger.RangerAuthorizerTest ‑ testAuthorizationAllow
com.datahub.authorization.ranger.RangerAuthorizerTest ‑ testAuthorizationDeny
com.datahub.authorizer.plugin.ranger.TestDataHubRangerAuthPlugin ‑ testLookupResource
com.datahub.authorizer.plugin.ranger.TestDataHubRangerAuthPlugin ‑ testValidateConfig

com.datahub.plugins.auth.TestConfig ‑ testConfig
com.datahub.plugins.auth.TestConfigProvider ‑ testConfigurationLoading
com.datahub.plugins.auth.TestConfigValidationUtils ‑ testListShouldNotBeEmpty
com.datahub.plugins.auth.TestConfigValidationUtils ‑ testListShouldNotHaveDuplicate
com.datahub.plugins.auth.TestConfigValidationUtils ‑ testMapShouldNotBeEmpty
com.datahub.plugins.auth.TestConfigValidationUtils ‑ testWhiteSpacesValidation
com.datahub.plugins.auth.TestIsolatedClassLoader ‑ testAuthenticatorPlugin
com.datahub.plugins.auth.TestIsolatedClassLoader ‑ testAuthorizerPlugin
com.datahub.plugins.auth.TestIsolatedClassLoader ‑ testDuplicatePluginName
com.datahub.plugins.auth.TestIsolatedClassLoader ‑ testIncorrectImplementation
…

♻️ This comment has been updated with latest results.

…auth-plugin

…:acryldata/datahub-fork into master+acr-3593-pluggable-auth-framework

…:mohdsiddique/datahub into master+acr-3593-pluggable-auth-framework

…:acryldata/datahub-fork into master+acr-3593-pluggable-auth-framework

jjoyce0510 · 2022-12-06T18:08:35Z

docs/how/updating-datahub.md

@@ -5,6 +5,10 @@ This file documents any backwards-incompatible changes in DataHub and assists pe
 ## Next

 ### Breaking Changes
+- #6243 apache-ranger authorizer is no longer the core part of DataHub GMS, and it is shifted as plugin. Please refer updated documentation [Configuring Authorization with Apache Ranger](./configuring-authorization-with-apache-ranger.md#configuring-your-datahub-deployment) for configuring `apache-ranger-plugin` in DataHub GMS.


jjoyce0510 · 2022-12-06T18:13:19Z

metadata-service/factories/build.gradle

@@ -24,9 +26,10 @@ dependencies {
  compile externalDependency.springCore
  compile externalDependency.springKafka
  compile externalDependency.springWeb
-  compile project(':metadata-service:auth-ranger-impl')
+


jjoyce0510 · 2022-12-06T18:17:21Z

metadata-service/factories/src/main/resources/application.yml

    entityRegistry:
-      path: ${ENTITY_REGISTRY_PLUGIN_PATH:/etc/datahub/plugins/models}
+        path: ${ENTITY_REGISTRY_PLUGIN_PATH:/etc/datahub/plugins/models}


this looks wrong to me

jjoyce0510 · 2022-12-06T18:18:48Z

metadata-service/plugin/src/main/java/com/datahub/plugins/common/SecurityMode.java

+  /**
+   * In this mode plugins has limited access.
+   *
+   * Plugins are allowed to connect on below ports only


jjoyce0510

Overall LGTM.

…b-project#6634)

siddiquebagwan-gslab added 30 commits September 29, 2022 19:23

rename package of auth-api to com.datahub.plugins.auth

b98ed89

type public

b10b578

rename com.datahub.auth

3eec5b6

move to metadata-auth

8a7d25f

copied original metadata-auth

ee98360

updated to point to metadata-auth

a177b99

metadata-auth:auth-api

44bf372

WIP

662cfae

Added plugin code

c82147d

plugin integrated

12e9699

config

472a1cc

integrated plugin into GMS

4719cc8

authenticator chain is working

fbe2ee2

allow log4j for apache-ranger-plugin

0683b55

Merge branch 'master' into master+acr-3593-pluggable-auth-framework

e526c3b

remove apache-ranger config from start.sh

6dfc3e2

Empty enumeration from findResources

a918b41

Working GMS with Pluggable Auth Framework

7d07e8c

doc

ea90984

fix javadoc error

34ca6c2

rename pluginDirectory to pluginHome

c202df3

doc update

7feb007

fix merge conflict

2884152

doc updated

c0d8ea2

doc fix

4cfcd82

resolve merge conflict

f3d3000

Merge branch 'master+acr-3593-pluggable-auth-framework' of github.com…

a2d6d76

…:acryldata/datahub-fork into master+acr-3593-pluggable-auth-framework

review comments

96403c2

Merge branch 'master+acr-3593-pluggable-auth-framework' of github.com…

0169754

…:acryldata/datahub-fork into master+acr-3593-pluggable-auth-framework

Remove unrelated classes from plugins folder

f251e1f

siddiquebagwan-gslab added 8 commits November 30, 2022 16:55

fix style

7bb0555

Merge branch 'master+acr-3593-pluggable-auth-framework' of github.com…

2b7b486

…:acryldata/datahub-fork into master+acr-3593-pluggable-auth-framework

resolve merge conflict

3debbc5

arrange gradle module in settings.gradle

e0a4dcf

Merge branch 'master' into master+acr-3593-pluggable-auth-framework

d3360ff

Merge branch 'master' into master+acr-3593-pluggable-auth-framework

10c003e

resolve merge conflict

3105593

Merge branch 'master+acr-3593-pluggable-auth-framework' of github.com…

78fc136

…:acryldata/datahub-fork into master+acr-3593-pluggable-auth-framework

github-actions bot added devops PR or Issue related to DataHub backend & deployment docs Issues and Improvements to docs product PR or Issue related to the DataHub UI/UX labels Dec 5, 2022

pedro93 and others added 11 commits December 5, 2022 09:58

Merge branch 'master' into master+acr-3593-pluggable-auth-framework

aaeb77b

Move apache-ranger related code to new repo acryldata/datahub-ranger-…

4355e58

…auth-plugin

resolve merge conflict

760745b

Merge branch 'master+acr-3593-pluggable-auth-framework' of github.com…

42e9d75

…:acryldata/datahub-fork into master+acr-3593-pluggable-auth-framework

Merge branch 'master+acr-3593-pluggable-auth-framework' of github.com…

c5d548a

…:mohdsiddique/datahub into master+acr-3593-pluggable-auth-framework

Fix issue in auth-api publish

914fbb8

publish shadow jar for datahub-auth-api

eebd3c8

Merge branch 'master' into master+acr-3593-pluggable-auth-framework

1b55634

Merge branch 'master+acr-3593-pluggable-auth-framework' of github.com…

4680cb4

…:acryldata/datahub-fork into master+acr-3593-pluggable-auth-framework

make normal jar

eeaab51

Merge branch 'master+acr-3593-pluggable-auth-framework' of github.com…

6665d53

…:acryldata/datahub-fork into master+acr-3593-pluggable-auth-framework

jjoyce0510 reviewed Dec 6, 2022

View reviewed changes

jjoyce0510 approved these changes Dec 6, 2022

View reviewed changes

jjoyce0510 merged commit f2a83f3 into datahub-project:master Dec 6, 2022

cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023

feat(gms): Pluggable Authentication & Authorization Framework (datahu…

614ef6b

…b-project#6634)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(gms): Pluggable Authentication & Authorization Framework #6634

feat(gms): Pluggable Authentication & Authorization Framework #6634

siddiquebagwan commented Dec 5, 2022

github-actions bot commented Dec 5, 2022 •

edited

Loading

jjoyce0510 Dec 6, 2022

jjoyce0510 Dec 6, 2022

jjoyce0510 Dec 6, 2022

jjoyce0510 Dec 6, 2022

jjoyce0510 left a comment

feat(gms): Pluggable Authentication & Authorization Framework #6634

feat(gms): Pluggable Authentication & Authorization Framework #6634

Conversation

siddiquebagwan commented Dec 5, 2022

github-actions bot commented Dec 5, 2022 • edited Loading

Unit Test Results (build & test)

jjoyce0510 Dec 6, 2022

Choose a reason for hiding this comment

jjoyce0510 Dec 6, 2022

Choose a reason for hiding this comment

jjoyce0510 Dec 6, 2022

Choose a reason for hiding this comment

jjoyce0510 Dec 6, 2022

Choose a reason for hiding this comment

jjoyce0510 left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 5, 2022 •

edited

Loading