feat(ingest): update snowflake docs, add simple validations #6636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
mayurinehate
commented
Dec 5, 2022
hsheth2
reviewed
Dec 5, 2022
| "role": "sysadmin", | ||
| } | ||
| ) | ||
| excinfo.value == f"Please remove trailing {SNOWFLAKE_HOST_SUFFIX} from `account_id`." |
There was a problem hiding this comment.
why can't we just do this automatically?
jjoyce0510
reviewed
Dec 6, 2022
| @@ -41,6 +41,8 @@ | |||
| "OAUTH_AUTHENTICATOR": OAUTH_AUTHENTICATOR, | |||
| } | |||
|
|
|||
| SNOWFLAKE_HOST_SUFFIX = ".snowflakecomputing.com" | |||
jjoyce0510
reviewed
Dec 6, 2022
| else: | ||
| if account_id.endswith(SNOWFLAKE_HOST_SUFFIX): | ||
| raise ValueError( | ||
| f"Please remove trailing {SNOWFLAKE_HOST_SUFFIX} from `account_id`." |
There was a problem hiding this comment.
Why don't we just do this for them? same as here? host_port = remove_suffix(host_port, SNOWFLAKE_HOST_SUFFIX)
remember, we should really avoid failing.
There was a problem hiding this comment.
got it. will change that.
mayurinehate
force-pushed
the
snowflake_docs_simplify
branch
from
c6ba081 to
5fba301
Compare
cccs-Dustin
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist