perf(ui-ingestion): cache on creation or deletion of ingestion sources to reduce latency #6647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-radhakrishnan
force-pushed
the
ar--12-05-cache-managed-ingestion
branch
from
1e2a84d to
18a6c7f
Compare
…s to reduce latency
aditya-radhakrishnan
force-pushed
the
ar--12-05-cache-managed-ingestion
branch
from
18a6c7f to
3cef938
Compare
jjoyce0510
reviewed
Dec 6, 2022
| @@ -197,6 +200,19 @@ export const IngestionSourceList = () => { | |||
| }); | |||
| } else { | |||
| // Create | |||
| const newSource = { | |||
| urn: PLACEHOLDER_URN, | |||
There was a problem hiding this comment.
So we still do the 3 second timeout? To refetch. I bet if we return the URN from the createSource call we wouldn't even need that followup
jjoyce0510
approved these changes
Dec 6, 2022
cccs-Dustin
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Feb 1, 2023
…s to reduce latency (datahub-project#6647)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Videos
Adding a Source
https://user-images.githubusercontent.com/19418814/205800167-75b8c351-1053-4718-91e2-3214e897842a.mov
Invalidating Cache on Add Failure
https://user-images.githubusercontent.com/19418814/205808636-ede4e509-36d9-4ffa-87f4-def7c8f26bb5.mov
Deleting a Source
https://user-images.githubusercontent.com/19418814/205800737-d035845b-50b2-4550-a89d-0db195c41985.mov
Checklist