-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest/dbt): add support for latest DBT version 1.3 #6651
feat(ingest/dbt): add support for latest DBT version 1.3 #6651
Conversation
9b6d1d4
to
a70978e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for the fix @MatthieuBlais
Out of curiosity - are you using dbt's Python support?
Unit Test Results (build & test)633 tests +11 629 ✔️ +11 16m 1s ⏱️ +24s Results for commit cd17d03. ± Comparison against base commit 7065971. This pull request removes 4 and adds 15 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Thanks @hsheth2 ! We are not using the python models yet, we're still in the process of upgrading to 1.3. |
…ject#6651) Co-authored-by: Matthieu Blais <[email protected]> Co-authored-by: Harshal Sheth <[email protected]>
DBT has released version 1.3 in October and they have updated the manifest schema to a newer version. It includes the following changes:
raw_sql
toraw_code
compiled_sql
tocompiled_code
language
(sql
orpython
)It would be great if Datahub can support this most recent version, so I would like to propose this PR to start the discussion about it. Feel free to share your thoughts!
Checklist