fix(posts): add deletePost GraphQL endpoint #6813
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| package com.linkedin.datahub.graphql.resolvers.post; | ||
|
|
||
| import com.datahub.authentication.Authentication; | ||
| import com.datahub.authentication.post.PostService; | ||
| import com.linkedin.common.urn.Urn; | ||
| import com.linkedin.common.urn.UrnUtils; | ||
| import com.linkedin.datahub.graphql.QueryContext; | ||
| import com.linkedin.datahub.graphql.authorization.AuthorizationUtils; | ||
| import com.linkedin.datahub.graphql.exception.AuthorizationException; | ||
| import graphql.schema.DataFetcher; | ||
| import graphql.schema.DataFetchingEnvironment; | ||
| import java.util.concurrent.CompletableFuture; | ||
| import lombok.RequiredArgsConstructor; | ||
| import lombok.extern.slf4j.Slf4j; | ||
|
|
||
|
|
||
| @Slf4j | ||
| @RequiredArgsConstructor | ||
| public class DeletePostResolver implements DataFetcher<CompletableFuture<Boolean>> { | ||
| private final PostService _postService; | ||
|
|
||
| @Override | ||
| public CompletableFuture<Boolean> get(final DataFetchingEnvironment environment) throws Exception { | ||
| final QueryContext context = environment.getContext(); | ||
|
|
||
| if (!AuthorizationUtils.canCreateGlobalAnnouncements(context)) { | ||
| throw new AuthorizationException( | ||
| "Unauthorized to delete posts. Please contact your DataHub administrator if this needs corrective action."); | ||
| } | ||
|
|
||
| final Urn postUrn = UrnUtils.getUrn(environment.getArgument("urn")); | ||
| final Authentication authentication = context.getAuthentication(); | ||
|
|
||
| return CompletableFuture.supplyAsync(() -> { | ||
| try { | ||
| return _postService.deletePost(postUrn, authentication); | ||
| } catch (Exception e) { | ||
| throw new RuntimeException("Failed to create a new post", e); | ||
| } | ||
| }); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| package com.linkedin.datahub.graphql.resolvers.post; | ||
|
|
||
| import com.datahub.authentication.Authentication; | ||
| import com.datahub.authentication.post.PostService; | ||
| import com.linkedin.common.urn.Urn; | ||
| import com.linkedin.common.urn.UrnUtils; | ||
| import com.linkedin.datahub.graphql.QueryContext; | ||
| import graphql.schema.DataFetchingEnvironment; | ||
| import org.testng.annotations.BeforeMethod; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| import static com.linkedin.datahub.graphql.TestUtils.*; | ||
| import static org.mockito.Mockito.*; | ||
| import static org.testng.Assert.*; | ||
|
|
||
|
|
||
| public class DeletePostResolverTest { | ||
| private static final String POST_URN_STRING = "urn:li:post:123"; | ||
| private PostService _postService; | ||
| private DeletePostResolver _resolver; | ||
| private DataFetchingEnvironment _dataFetchingEnvironment; | ||
| private Authentication _authentication; | ||
|
|
||
| @BeforeMethod | ||
| public void setupTest() throws Exception { | ||
| _postService = mock(PostService.class); | ||
| _dataFetchingEnvironment = mock(DataFetchingEnvironment.class); | ||
| _authentication = mock(Authentication.class); | ||
|
|
||
| _resolver = new DeletePostResolver(_postService); | ||
| } | ||
|
|
||
| @Test | ||
| public void testNotAuthorizedFails() { | ||
| QueryContext mockContext = getMockDenyContext(); | ||
| when(_dataFetchingEnvironment.getContext()).thenReturn(mockContext); | ||
|
|
||
| assertThrows(() -> _resolver.get(_dataFetchingEnvironment).join()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testDeletePost() throws Exception { | ||
| Urn postUrn = UrnUtils.getUrn(POST_URN_STRING); | ||
|
|
||
| QueryContext mockContext = getMockAllowContext(); | ||
| when(_dataFetchingEnvironment.getContext()).thenReturn(mockContext); | ||
| when(mockContext.getAuthentication()).thenReturn(_authentication); | ||
| when(_dataFetchingEnvironment.getArgument(eq("urn"))).thenReturn(POST_URN_STRING); | ||
| when(_postService.deletePost(eq(postUrn), eq(_authentication))).thenReturn(true); | ||
|
|
||
| assertTrue(_resolver.get(_dataFetchingEnvironment).join()); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, once the scope of Posts expands, we will need to change this permission. Maybe it's better to check the owner of the post.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This addresses the use case for now, and we can get it in immediately. But I'd like to discuss this one offline a bit more.