chore(ingest): remove inferred args to MCPW, part 1

metadata-ingestion/as-a-library.md

@@ -21,7 +21,7 @@ pip install -U `acryl-datahub[datahub-rest]`
 ```python
 import datahub.emitter.mce_builder as builder
 from datahub.emitter.mcp import MetadataChangeProposalWrapper
-from datahub.metadata.schema_classes import ChangeTypeClass, DatasetPropertiesClass
+from datahub.metadata.schema_classes import DatasetPropertiesClass
 
 from datahub.emitter.rest_emitter import DatahubRestEmitter
 
@@ -39,10 +39,7 @@ dataset_properties = DatasetPropertiesClass(description="This table stored the c
 
 # Construct a MetadataChangeProposalWrapper object.
 metadata_event = MetadataChangeProposalWrapper(
-    entityType="dataset",
-    changeType=ChangeTypeClass.UPSERT,
     entityUrn=builder.make_dataset_urn("bigquery", "my-project.my-dataset.user-table"),
-    aspectName="datasetProperties",
     aspect=dataset_properties,
 )
 
@@ -75,7 +72,7 @@ pip install -U `acryl-datahub[datahub-kafka]`
 ```python
 import datahub.emitter.mce_builder as builder
 from datahub.emitter.mcp import MetadataChangeProposalWrapper
-from datahub.metadata.schema_classes import ChangeTypeClass, DatasetPropertiesClass
+from datahub.metadata.schema_classes import DatasetPropertiesClass
 
 from datahub.emitter.kafka_emitter import DatahubKafkaEmitter, KafkaEmitterConfig
 # Create an emitter to Kafka
@@ -100,10 +97,7 @@ dataset_properties = DatasetPropertiesClass(description="This table stored the c
 
 # Construct a MetadataChangeProposalWrapper object.
 metadata_event = MetadataChangeProposalWrapper(
-    entityType="dataset",
-    changeType=ChangeTypeClass.UPSERT,
     entityUrn=builder.make_dataset_urn("bigquery", "my-project.my-dataset.user-table"),
-    aspectName="datasetProperties",
     aspect=dataset_properties,
 )
 

metadata-ingestion/examples/library/dashboard_usage.py

@@ -9,7 +9,6 @@
 # Imports for metadata model classes
 from datahub.metadata.schema_classes import (
     CalendarIntervalClass,
-    ChangeTypeClass,
     DashboardUsageStatisticsClass,
     DashboardUserUsageCountsClass,
     TimeWindowSizeClass,
@@ -28,10 +27,7 @@
 ]
 
 usage_day_1: MetadataChangeProposalWrapper = MetadataChangeProposalWrapper(
-    entityType="dashboard",
-    changeType=ChangeTypeClass.UPSERT,
     entityUrn=make_dashboard_urn("looker", "dashboards.999999"),
-    aspectName="dashboardUsageStatistics",
     aspect=DashboardUsageStatisticsClass(
         timestampMillis=round(
             datetime.strptime("2022-02-09", "%Y-%m-%d").timestamp() * 1000
@@ -45,10 +41,7 @@
 
 absolute_usage_as_of_day_1: MetadataChangeProposalWrapper = (
     MetadataChangeProposalWrapper(
-        entityType="dashboard",
-        changeType=ChangeTypeClass.UPSERT,
         entityUrn=make_dashboard_urn("looker", "dashboards.999999"),
-        aspectName="dashboardUsageStatistics",
         aspect=DashboardUsageStatisticsClass(
             timestampMillis=round(
                 datetime.strptime("2022-02-09", "%Y-%m-%d").timestamp() * 1000
@@ -77,10 +70,7 @@
     ),
 ]
 usage_day_2: MetadataChangeProposalWrapper = MetadataChangeProposalWrapper(
-    entityType="dashboard",
-    changeType=ChangeTypeClass.UPSERT,
     entityUrn=make_dashboard_urn("looker", "dashboards.999999"),
-    aspectName="dashboardUsageStatistics",
     aspect=DashboardUsageStatisticsClass(
         timestampMillis=round(
             datetime.strptime("2022-02-10", "%Y-%m-%d").timestamp() * 1000
@@ -94,10 +84,7 @@
 
 absolute_usage_as_of_day_2: MetadataChangeProposalWrapper = (
     MetadataChangeProposalWrapper(
-        entityType="dashboard",
-        changeType=ChangeTypeClass.UPSERT,
         entityUrn=make_dashboard_urn("looker", "dashboards.999999"),
-        aspectName="dashboardUsageStatistics",
         aspect=DashboardUsageStatisticsClass(
             timestampMillis=round(
                 datetime.strptime("2022-02-10", "%Y-%m-%d").timestamp() * 1000
@@ -123,10 +110,7 @@
     ),
 ]
 usage_day_3: MetadataChangeProposalWrapper = MetadataChangeProposalWrapper(
-    entityType="dashboard",
-    changeType=ChangeTypeClass.UPSERT,
     entityUrn=make_dashboard_urn("looker", "dashboards.999999"),
-    aspectName="dashboardUsageStatistics",
     aspect=DashboardUsageStatisticsClass(
         timestampMillis=round(
             datetime.strptime("2022-02-11", "%Y-%m-%d").timestamp() * 1000
@@ -140,10 +124,7 @@
 
 absolute_usage_as_of_day_3: MetadataChangeProposalWrapper = (
     MetadataChangeProposalWrapper(
-        entityType="dashboard",
-        changeType=ChangeTypeClass.UPSERT,
         entityUrn=make_dashboard_urn("looker", "dashboards.999999"),
-        aspectName="dashboardUsageStatistics",
         aspect=DashboardUsageStatisticsClass(
             timestampMillis=round(
                 datetime.strptime("2022-02-11", "%Y-%m-%d").timestamp() * 1000

metadata-ingestion/examples/library/data_quality_mcpw_rest.py

@@ -21,7 +21,6 @@
 )
 from datahub.metadata.com.linkedin.pegasus2avro.common import DataPlatformInstance
 from datahub.metadata.com.linkedin.pegasus2avro.dataset import DatasetProperties
-from datahub.metadata.com.linkedin.pegasus2avro.events.metadata import ChangeType
 from datahub.metadata.com.linkedin.pegasus2avro.timeseries import PartitionSpec
 
 
@@ -39,10 +38,7 @@ def assertionUrn(info: AssertionInfo) -> str:
 
 def emitAssertionResult(assertionResult: AssertionRunEvent) -> None:
     dataset_assertionRunEvent_mcp = MetadataChangeProposalWrapper(
-        entityType="assertion",
-        changeType=ChangeType.UPSERT,
         entityUrn=assertionResult.assertionUrn,
-        aspectName="assertionRunEvent",
         aspect=assertionResult,
     )
 
@@ -58,10 +54,7 @@ def emitAssertionResult(assertionResult: AssertionRunEvent) -> None:
 )
 # Construct a MetadataChangeProposalWrapper object for dataset
 dataset_mcp = MetadataChangeProposalWrapper(
-    entityType="dataset",
-    changeType=ChangeType.UPSERT,
     entityUrn=datasetUrn("bazTable"),
-    aspectName="datasetProperties",
     aspect=datasetProperties,
 )
 
@@ -93,10 +86,7 @@ def emitAssertionResult(assertionResult: AssertionRunEvent) -> None:
 
 # Construct a MetadataChangeProposalWrapper object.
 assertion_maxVal_mcp = MetadataChangeProposalWrapper(
-    entityType="assertion",
-    changeType=ChangeType.UPSERT,
     entityUrn=assertionUrn(assertion_maxVal),
-    aspectName="assertionInfo",
     aspect=assertion_maxVal,
 )
 
@@ -110,10 +100,7 @@ def emitAssertionResult(assertionResult: AssertionRunEvent) -> None:
 
 # Construct a MetadataChangeProposalWrapper object for assertion platform
 assertion_dataPlatformInstance_mcp = MetadataChangeProposalWrapper(
-    entityType="assertion",
-    changeType=ChangeType.UPSERT,
     entityUrn=assertionUrn(assertion_maxVal),
-    aspectName="dataPlatformInstance",
     aspect=assertion_dataPlatformInstance,
 )
 # Emit Assertion entity platform aspect!

metadata-ingestion/examples/library/dataset_add_column_term.py

@@ -10,7 +10,6 @@
 # Imports for metadata model classes
 from datahub.metadata.schema_classes import (
     AuditStampClass,
-    ChangeTypeClass,
     EditableSchemaFieldInfoClass,
     EditableSchemaMetadataClass,
     GlossaryTermAssociationClass,
@@ -94,10 +93,7 @@ def get_simple_field_path_from_v2_field_path(field_path: str) -> str:
 
 if need_write:
     event: MetadataChangeProposalWrapper = MetadataChangeProposalWrapper(
-        entityType="dataset",
-        changeType=ChangeTypeClass.UPSERT,
         entityUrn=dataset_urn,
-        aspectName="editableSchemaMetadata",
         aspect=current_editable_schema_metadata,
     )
     graph.emit(event)

metadata-ingestion/examples/library/dataset_schema.py

@@ -6,7 +6,6 @@
 # Imports for metadata model classes
 from datahub.metadata.schema_classes import (
     AuditStampClass,
-    ChangeTypeClass,
     DateTypeClass,
     OtherSchemaClass,
     SchemaFieldClass,
@@ -16,10 +15,7 @@
 )
 
 event: MetadataChangeProposalWrapper = MetadataChangeProposalWrapper(
-    entityType="dataset",
-    changeType=ChangeTypeClass.UPSERT,
     entityUrn=make_dataset_urn(platform="hive", name="realestate_db.sales", env="PROD"),
-    aspectName="schemaMetadata",
     aspect=SchemaMetadataClass(
         schemaName="customer",  # not used
         platform=make_data_platform_urn("hive"),  # important <- platform must be an urn

metadata-ingestion/examples/library/dataset_schema_with_tags_terms.py

@@ -12,7 +12,6 @@
 # Imports for metadata model classes
 from datahub.metadata.schema_classes import (
     AuditStampClass,
-    ChangeTypeClass,
     GlobalTagsClass,
     GlossaryTermAssociationClass,
     GlossaryTermsClass,
@@ -25,10 +24,7 @@
 )
 
 event: MetadataChangeProposalWrapper = MetadataChangeProposalWrapper(
-    entityType="dataset",
-    changeType=ChangeTypeClass.UPSERT,
     entityUrn=make_dataset_urn(platform="hive", name="foodb.barTable", env="PROD"),
-    aspectName="schemaMetadata",
     aspect=SchemaMetadataClass(
         schemaName="customer",  # not used
         platform=make_data_platform_urn("hive"),  # important <- platform must be an urn

metadata-ingestion/examples/library/dataset_set_tag.py

@@ -6,22 +6,15 @@
 from datahub.emitter.rest_emitter import DatahubRestEmitter
 
 # Imports for metadata model classes
-from datahub.metadata.schema_classes import (
-    ChangeTypeClass,
-    GlobalTagsClass,
-    TagAssociationClass,
-)
+from datahub.metadata.schema_classes import GlobalTagsClass, TagAssociationClass
 
 log = logging.getLogger(__name__)
 logging.basicConfig(level=logging.INFO)
 
 dataset_urn = make_dataset_urn(platform="hive", name="realestate_db.sales", env="PROD")
 tag_urn = make_tag_urn("purchase")
 event: MetadataChangeProposalWrapper = MetadataChangeProposalWrapper(
-    entityType="dataset",
-    changeType=ChangeTypeClass.UPSERT,
     entityUrn=dataset_urn,
-    aspectName="globalTags",
     aspect=GlobalTagsClass(tags=[TagAssociationClass(tag=tag_urn)]),
 )
 

metadata-ingestion/examples/library/dataset_set_term.py

@@ -7,7 +7,6 @@
 # Imports for metadata model classes
 from datahub.metadata.schema_classes import (
     AuditStampClass,
-    ChangeTypeClass,
     GlossaryTermAssociationClass,
     GlossaryTermsClass,
 )
@@ -34,10 +33,7 @@
 )
 
 event: MetadataChangeProposalWrapper = MetadataChangeProposalWrapper(
-    entityType="dataset",
-    changeType=ChangeTypeClass.UPSERT,
     entityUrn=dataset_urn,
-    aspectName="glossaryTerms",
     aspect=terms_aspect,
 )
 rest_emitter.emit(event)

metadata-ingestion/examples/library/lineage_chart_dashboard.py

@@ -4,7 +4,7 @@
 from datahub.emitter.mcp import MetadataChangeProposalWrapper
 from datahub.emitter.rest_emitter import DatahubRestEmitter
 from datahub.metadata.com.linkedin.pegasus2avro.dashboard import DashboardInfoClass
-from datahub.metadata.schema_classes import ChangeAuditStampsClass, ChangeTypeClass
+from datahub.metadata.schema_classes import ChangeAuditStampsClass
 
 # Construct the DashboardInfo aspect with the charts -> dashboard lineage.
 charts_in_dashboard: List[str] = [
@@ -25,10 +25,7 @@
 # Construct a MetadataChangeProposalWrapper object with the DashboardInfo aspect.
 # NOTE: This will overwrite all of the existing dashboard aspect information associated with this dashboard.
 chart_info_mcp = MetadataChangeProposalWrapper(
-    entityType="dashboard",
-    changeType=ChangeTypeClass.UPSERT,
     entityUrn=builder.make_dashboard_urn(platform="looker", name="my_dashboard_1"),
-    aspectName="dashboardInfo",
     aspect=dashboard_info,
 )
 

metadata-ingestion/examples/library/lineage_dataset_chart.py

@@ -4,7 +4,7 @@
 from datahub.emitter.mcp import MetadataChangeProposalWrapper
 from datahub.emitter.rest_emitter import DatahubRestEmitter
 from datahub.metadata.com.linkedin.pegasus2avro.chart import ChartInfoClass
-from datahub.metadata.schema_classes import ChangeAuditStampsClass, ChangeTypeClass
+from datahub.metadata.schema_classes import ChangeAuditStampsClass
 
 # Construct the ChartInfo aspect with the input_datasets lineage.
 input_datasets: List[str] = [
@@ -24,10 +24,7 @@
 # Construct a MetadataChangeProposalWrapper object with the ChartInfo aspect.
 # NOTE: This will overwrite all of the existing chartInfo aspect information associated with this chart.
 chart_info_mcp = MetadataChangeProposalWrapper(
-    entityType="chart",
-    changeType=ChangeTypeClass.UPSERT,
     entityUrn=builder.make_chart_urn(platform="looker", name="my_chart_1"),
-    aspectName="chartInfo",
     aspect=chart_info,
 )
 

metadata-ingestion/examples/library/lineage_dataset_job_dataset.py

@@ -4,7 +4,6 @@
 from datahub.emitter.mcp import MetadataChangeProposalWrapper
 from datahub.emitter.rest_emitter import DatahubRestEmitter
 from datahub.metadata.com.linkedin.pegasus2avro.datajob import DataJobInputOutputClass
-from datahub.metadata.schema_classes import ChangeTypeClass
 
 # Construct the DataJobInputOutput aspect.
 input_datasets: List[str] = [
@@ -33,12 +32,9 @@
 # Construct a MetadataChangeProposalWrapper object.
 # NOTE: This will overwrite all of the existing lineage information associated with this job.
 datajob_input_output_mcp = MetadataChangeProposalWrapper(
-    entityType="dataJob",
-    changeType=ChangeTypeClass.UPSERT,
     entityUrn=builder.make_data_job_urn(
         orchestrator="airflow", flow_id="flow1", job_id="job1", cluster="PROD"
     ),
-    aspectName="dataJobInputOutput",
     aspect=datajob_input_output,
 )
 

metadata-ingestion/examples/library/lineage_emitter_datajob_finegrained.py

@@ -6,7 +6,7 @@
     FineGrainedLineageDownstreamType,
     FineGrainedLineageUpstreamType,
 )
-from datahub.metadata.schema_classes import ChangeTypeClass, DataJobInputOutputClass
+from datahub.metadata.schema_classes import DataJobInputOutputClass
 
 
 def datasetUrn(tbl):
@@ -100,10 +100,7 @@ def fldUrn(tbl, fld):
 )
 
 dataJobLineageMcp = MetadataChangeProposalWrapper(
-    entityType="dataJob",
-    changeType=ChangeTypeClass.UPSERT,
     entityUrn=builder.make_data_job_urn("spark", "Flow1", "Task1"),
-    aspectName="dataJobInputOutput",
     aspect=dataJobInputOutput,
 )
 

metadata-ingestion/examples/library/lineage_emitter_dataset_finegrained.py

@@ -9,7 +9,6 @@
     Upstream,
     UpstreamLineage,
 )
-from datahub.metadata.schema_classes import ChangeTypeClass
 
 
 def datasetUrn(tbl):
@@ -75,10 +74,7 @@ def fldUrn(tbl, fld):
 )
 
 lineageMcp = MetadataChangeProposalWrapper(
-    entityType="dataset",
-    changeType=ChangeTypeClass.UPSERT,
     entityUrn=datasetUrn("bar"),
-    aspectName="upstreamLineage",
     aspect=fieldLineages,
 )
 

metadata-ingestion/examples/library/lineage_emitter_mcpw_rest.py

@@ -8,7 +8,6 @@
     UpstreamClass,
     UpstreamLineage,
 )
-from datahub.metadata.schema_classes import ChangeTypeClass
 
 upstream_table_1 = UpstreamClass(
     dataset=builder.make_dataset_urn("bigquery", "upstream_table_1", "PROD"),
@@ -26,10 +25,7 @@
 
 # Construct a MetadataChangeProposalWrapper object.
 lineage_mcp = MetadataChangeProposalWrapper(
-    entityType="dataset",
-    changeType=ChangeTypeClass.UPSERT,
     entityUrn=builder.make_dataset_urn("bigquery", "downstream"),
-    aspectName="upstreamLineage",
     aspect=upstream_lineage,
 )