Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Make datahub quickstart work with latest docker compose in M1 #6891

Merged
merged 2 commits into from
Dec 30, 2022
Merged

fix(cli): Make datahub quickstart work with latest docker compose in M1 #6891

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d8f891
fix(cli): Make datahub quickstart work with latest docker compose in M1
pedro93 Dec 29, 2022
ecb6723
Update metadata-ingestion/src/datahub/cli/docker_cli.py
hsheth2 Dec 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions metadata-ingestion/src/datahub/cli/docker_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,15 +71,8 @@ class Architectures(Enum):

@functools.lru_cache()
def _docker_subprocess_env() -> Dict[str, str]:
try:
DOCKER_COMPOSE_PLATFORM: Optional[str] = (
subprocess.run(["uname", "-m"], stdout=subprocess.PIPE)
.stdout.decode("utf-8")
.rstrip()
)
except FileNotFoundError:
# On Windows, uname is not available.
DOCKER_COMPOSE_PLATFORM = None
# platform.machine() is equivalent to `uname -m`, as per https://stackoverflow.com/a/45124927/5004662
DOCKER_COMPOSE_PLATFORM: str = "linux/" + platform.machine()

env = {
**os.environ,
Expand Down