fix(ingest): use snowflake median function in profiling #6987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
jjoyce0510
reviewed
Jan 10, 2023
jjoyce0510
reviewed
Jan 10, 2023
| @@ -358,7 +359,16 @@ def _get_dataset_column_median( | |||
| if not self.config.include_field_median_value: | |||
| return | |||
| try: | |||
| column_profile.median = str(self.dataset.get_column_median(column)) | |||
| if self.dataset.engine.dialect.name.lower() == "snowflake": | |||
There was a problem hiding this comment.
Are these dialect names defined in a central config somewhere?
There was a problem hiding this comment.
no - these come from sqlalchemy's dialect names
agree that we should refactor into an enum (GE itself did a similar thing a few months ago), but probably for a separate PR
ericyomi
pushed a commit
to ericyomi/datahub
that referenced
this pull request
Feb 8, 2023
oleg-ruban
pushed a commit
to RChygir/datahub
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested via https://datahubspace.slack.com/archives/CUMUWQU66/p1673264591225749.
Checklist