Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/kafka): fix ResourceType import error for confluent_kafka<1.9.0 #7046

Merged
merged 1 commit into from
Jan 17, 2023
Merged

fix(ingest/kafka): fix ResourceType import error for confluent_kafka<1.9.0 #7046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions metadata-ingestion/src/datahub/ingestion/source/kafka.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
AdminClient,
ConfigEntry,
ConfigResource,
ResourceType,
TopicMetadata,
)

Expand Down Expand Up @@ -404,11 +403,10 @@ def fetch_extra_topic_details(self, topics: List[str]) -> Dict[str, dict]:

def fetch_topic_configurations(self, topics: List[str]) -> Dict[str, dict]:
logger.info("Fetching config details for all topics")

configs: Dict[
ConfigResource, concurrent.futures.Future
] = self.admin_client.describe_configs(
resources=[ConfigResource(ResourceType.TOPIC, t) for t in topics],
resources=[ConfigResource(ConfigResource.Type.TOPIC, t) for t in topics],
request_timeout=self.source_config.connection.client_timeout_seconds,
)
logger.debug("Waiting for config details futures to complete")
Expand Down