fix(ui) Fix duplicate schema field rendering with siblings #7057
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue reported by several users where scrolling on their schema caused the same field to be repeated and take over the whole schema. This was happening because the
key
of one (or more) the schema rows had a duplicate, causing bad rendering issues and duplicating the same rows.This could happen when two siblings had different schemas. If one of the schemas had an extra row or two inserted in the middle, the two schemas would be merged by index and therefore we would produce duplicate fields, causing duplicate rows, breaking the schema renderer.
This fixes the issue by merging based on the
fieldPath
instead, so now we get a combined schema of the siblings with unique field paths, preventing duplicated.Checklist