Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui) Make checkboxes in ingestion forms easier to see #7061

Conversation

chriscollins3456
Copy link
Collaborator

The checkboxes in our ingestion form when not checked had so little contrast you could hardly see them. This just darkens them when they're not checked. it sets the border color to be the primary color when they are checked (as it was before, but I just need to be explicit in code now)

before:
image

after:
image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jan 18, 2023
@jjoyce0510
Copy link
Collaborator

Looks like build is failing!

Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will wait for tests to pass then good to merge!

@chriscollins3456 chriscollins3456 merged commit 24be154 into datahub-project:master Jan 18, 2023
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Jan 18, 2023
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants