Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): support snapshots in dbt and dbt-cloud #7062

Merged
merged 7 commits into from
Jan 18, 2023
Merged

feat(ingest): support snapshots in dbt and dbt-cloud #7062

merged 7 commits into from
Jan 18, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jan 18, 2023 •
edited
Loading

  • Adds snapshots support in dbt core and dbt cloud
  • Refactors entities_enabled handling
  • Remove some redundant tests
  • Add tests for dbt-core snapshot handling. I tested dbt cloud manually.

What it looks like in the UI:

image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 18, 2023
@anshbansal anshbansal requested a review from treff7es January 18, 2023 09:50
treff7es
treff7es approved these changes Jan 18, 2023
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/dbt/dbt_core.py
@@ -389,11 +389,6 @@ def load_file_as_json(self, uri: str) -> Any:

def loadManifestAndCatalog(
self,
manifest_path: str,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

metadata-ingestion/src/datahub/ingestion/source/dbt/dbt_cloud.py
@@ -93,7 +93,7 @@ class DBTCloudConfig(DBTCommonConfig):
#}
"""

_DBT_GRAPHQL_MODEL_SEED_FIELDS = """
_DBT_GRAPHQL_MODEL_SEED_SNAPSHOT_FIELDS = """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean on dbt cloud we supported Snapshot field earlier or why did you rename it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a set of common fields that we use for models, seeds, and snapshots

@hsheth2 hsheth2 merged commit fc41f45 into datahub-project:master Jan 18, 2023
@hsheth2 hsheth2 deleted the dbt-identifiers branch January 18, 2023 16:35
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Jan 18, 2023
@hsheth2 @treff7es @shirshanka
feat(ingest): support snapshots in dbt and dbt-cloud (datahub-project…
5cf0d75 
…#7062)

Co-authored-by: Tamas Nemeth <[email protected]>
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Jan 18, 2023
@hsheth2 @treff7es
feat(ingest): support snapshots in dbt and dbt-cloud (datahub-project…
63deeba 
…#7062)

Co-authored-by: Tamas Nemeth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @treff7es