fix(ingest): support git clone of non-github repos #7065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
jjoyce0510
reviewed
Jan 18, 2023
| if repo.startswith(_GITHUB_PREFIX): | ||
| return f"[email protected]:{repo[len(_GITHUB_PREFIX):]}.git" | ||
| elif repo.startswith(_GITLAB_PREFIX): | ||
| return f"[email protected]:{repo[len(_GITLAB_PREFIX):]}.git" |
There was a problem hiding this comment.
Nice - this is really awesome!! I was hoping we'd be able to generalize this
jjoyce0510
reviewed
Jan 18, 2023
| config.get_url_for_file_path( | ||
| "cmd/admin.go" | ||
| ) == "https://gitea.com/gitea/tea/src/branch/main/cmd/admin.go" | ||
| config.repo_ssh_locator == "https://gitea.com/gitea/tea.git" |
jjoyce0510
reviewed
Jan 18, 2023
| ) | ||
| branch: str = Field( | ||
| "main", | ||
| description="Branch on which your files live by default. Typically main or master. This can also be a commit hash.", | ||
| ) | ||
| base_url: str = Field( |
There was a problem hiding this comment.
Are we safe to remove this? Do we want to have any mapping?
jjoyce0510
reviewed
Jan 18, 2023
| def simplify_repo_url(cls, repo: str) -> str: | ||
| if repo.startswith("github.com/"): | ||
| repo = f"https://{repo}" | ||
| elif repo.startswith("gitlab.com"): |
There was a problem hiding this comment.
do we want any trailing slash like github case
jjoyce0510
reviewed
Jan 18, 2023
| elif repo.startswith("gitlab.com"): | ||
| repo = f"https://{repo}" | ||
| elif repo.count("/") == 1: | ||
| repo = f"https://github.com/{repo}" |
jjoyce0510
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist