Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Documentation Editor Improvements #7072

Merged
merged 19 commits into from
Jan 20, 2023
Merged

feat(ui): Documentation Editor Improvements #7072

merged 19 commits into from
Jan 20, 2023

Conversation

jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Jan 18, 2023 •
edited
Loading

Summary

A few features we added in this PR:

  1. Full-Screen Documentation Preview
  2. Persisted "last location" in the browser, so that opening a new tab seamlessly drops user back into context

The combination of these 2 provides a pretty awesome documentation editing experience.

Status

Ready for review

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jan 18, 2023
chriscollins3456
chriscollins3456 approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good to me! i have a couple of nits so feel free to take or leave them

datahub-web-react/src/app/entity/shared/tabs/Documentation/DocumentationTab.tsx Outdated Show resolved Hide resolved
datahub-web-react/src/app/context/UserContextProvider.tsx Outdated Show resolved Hide resolved
datahub-web-react/src/app/context/UserContextProvider.tsx Outdated Show resolved Hide resolved
datahub-web-react/src/app/entity/shared/tabs/Documentation/components/DescriptionEditor.tsx Show resolved Hide resolved
@jjoyce0510 jjoyce0510 merged commit 72f0328 into datahub-project:master Jan 20, 2023
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
@jjoyce0510
feat(ui): Documentation Editor Improvements (datahub-project#7072)
6de7507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjoyce0510 @chriscollins3456