fix(ingest/bigquery): clear stateful ingestion correctly #7075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, we would correctly soft-delete entities, but we wouldn't clear them out of the state payload. This means that every subsequent ingestion run would also try to soft delete those entities. This should require no intervention to roll out the changes.
github-actions
bot
added
the
ingestion
ericyomi
pushed a commit
to ericyomi/datahub
that referenced
this pull request
Feb 8, 2023
…ject#7075) Co-authored-by: Tamas Nemeth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, we would correctly soft-delete entities, but we wouldn't clear them out of the state payload. This means that every subsequent ingestion run would also try to soft delete those entities. This should require no intervention to roll out the changes.
Minor related change: fixes the reporting usage so that we only report each entity once. This ensures that the ingestion reports we produce are accurate. We were previously double-counting everything.
Checklist