feat(ingest): hide cartesian product warnings in GE profiler #7096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
jjoyce0510
reviewed
Jan 21, 2023
| @@ -333,7 +340,10 @@ def _execute_queue(self, main_greenlet: greenlet.greenlet) -> None: | |||
| # Extract the results into a result for each query. | |||
| index = 0 | |||
| for _, query_future in pending_queue.items(): | |||
| cols = query_future.query.columns | |||
| query = query_future.query | |||
| if IS_SQLALCHEMY_1_4: | |||
There was a problem hiding this comment.
Why is this part necessary? The subquery piece, whereas previously it was not
There was a problem hiding this comment.
not necessary - just suppresses a different warning that SA produces
|
@hsheth2 there is a linter error in the pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist