Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): move datahub-lite to optional dep and add shim when missing #7097

Merged
merged 2 commits into from
Jan 21, 2023
Merged

feat(ingest): move datahub-lite to optional dep and add shim when missing #7097

merged 2 commits into from
Jan 21, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jan 20, 2023 •
edited
Loading

Looks like this:

image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 20, 2023
shirshanka
shirshanka approved these changes Jan 21, 2023
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jjoyce0510
jjoyce0510 reviewed Jan 21, 2023
View reviewed changes
metadata-ingestion/src/datahub/entrypoints.py
@@ -155,15 +155,25 @@ def init() -> None:
datahub.add_command(telemetry_cli)
datahub.add_command(migrate)
datahub.add_command(timeline)
datahub.add_command(lite)

try:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome changes here.

jjoyce0510
jjoyce0510 reviewed Jan 21, 2023
View reviewed changes
metadata-ingestion/src/datahub/cli/cli_utils.py
@@ -704,3 +704,25 @@ def get_aspects_for_entity(
return {k: v for (k, v) in aspect_map.items() if k in aspects}
else:
return dict(aspect_map)


def make_shim_command(name: str, suggestion: str) -> click.Command:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice!

@hsheth2 hsheth2 merged commit 54c5017 into datahub-project:master Jan 21, 2023
@hsheth2 hsheth2 deleted the lite-shim branch January 21, 2023 01:24
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
@hsheth2
feat(ingest): move datahub-lite to optional dep and add shim when mis…
33476f1 
…sing (datahub-project#7097)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @shirshanka @jjoyce0510