test(ingest): fix kafka admin client mocking #7098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should shave 7-8 minutes off of our testQuick duration. Our testQuick runs were looking suspiciously close to 60s and 120s. From https://github.com/datahub-project/datahub/actions/runs/3969149209/jobs/6803245858: ``` 120.03s call tests/unit/test_kafka_source.py::test_kafka_source_workunits_topic_pattern 60.03s call tests/unit/test_kafka_source.py::test_kafka_source_workunits_schema_registry_subject_name_strategies 60.03s call tests/unit/test_kafka_source.py::test_kafka_ignore_warnings_on_schema_type[ignore_warnings_on_schema_type-FALSE] 60.03s call tests/unit/test_kafka_source.py::test_kafka_ignore_warnings_on_schema_type[ignore_warnings_on_schema_type-TRUE] 60.02s call tests/unit/test_kafka_source.py::test_kafka_source_workunits_wildcard_topic 60.02s call tests/unit/test_kafka_source.py::test_kafka_source_workunits_with_platform_instance ```
github-actions
bot
added
the
ingestion
treff7es
approved these changes
Jan 23, 2023
ericyomi
pushed a commit
to ericyomi/datahub
that referenced
this pull request
Feb 8, 2023
Co-authored-by: Tamas Nemeth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should shave 7-8 minutes off of our testQuick duration.
Our testQuick runs were looking suspiciously close to 60s and 120s. From https://github.com/datahub-project/datahub/actions/runs/3969149209/jobs/6803245858:
These tests now all run in <1s.
Checklist