Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/profile): properly quoting approx_count_distinct #7101

Merged
merged 8 commits into from
Jan 24, 2023
Merged

fix(ingest/profile): properly quoting approx_count_distinct #7101

merged 8 commits into from
Jan 24, 2023

Conversation

treff7es
Copy link
Contributor

  • properly quoting approx count query
  • Fixing deprecated api calls in bigquery

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@treff7es
- properly quoting approx count query
73c0a4c 
- Fixing deprecated api calls in bigquery
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 23, 2023
hsheth2
hsheth2 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjoyce0510 jjoyce0510 merged commit e92ce16 into datahub-project:master Jan 24, 2023
hsheth2 added a commit to hsheth2/datahub that referenced this pull request Jan 26, 2023
@hsheth2
fix(ingest/snowflake): fix regression in approx count distinct
2161433 
Follow up on datahub-project#7101.
@hsheth2 hsheth2 mentioned this pull request Jan 26, 2023
Merged
5 tasks
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
@treff7es
fix(ingest/profile): properly quoting approx_count_distinct (datahub-…
0b3e6a8 
…project#7101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@treff7es @hsheth2 @jjoyce0510