Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(models): Replaces non-ASCII charactes in pdl files with ASCII c… #7105

Merged
merged 1 commit into from
Jan 24, 2023
Merged

style(models): Replaces non-ASCII charactes in pdl files with ASCII c… #7105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions li-utils/src/main/pegasus/com/linkedin/common/MLFeatureDataType.pdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ enum MLFeatureDataType {
USELESS

/**
* Nominal data is made of discrete values with no numerical relationship between the different categories — mean and median are meaningless.
* Nominal data is made of discrete values with no numerical relationship between the different categories - mean and median are meaningless.
* Animal species is one example. For example, pig is not higher than bird and lower than fish.
*/
NOMINAL
Expand All @@ -24,19 +24,19 @@ enum MLFeatureDataType {
ORDINAL

/**
* Binary data is discrete data that can be in only one of two categories — either yes or no, 1 or 0, off or on, etc
* Binary data is discrete data that can be in only one of two categories - either yes or no, 1 or 0, off or on, etc
*/
BINARY

/**
* Count data is discrete whole number data — no negative numbers here.
* Count data is discrete whole number data - no negative numbers here.
* Count data often has many small values, such as zero and one.
*/
COUNT

/**
* Time data is a cyclical, repeating continuous form of data.
* The relevant time features can be any period— daily, weekly, monthly, annual, etc.
* The relevant time features can be any period- daily, weekly, monthly, annual, etc.
*/
TIME

Expand Down
2 changes: 1 addition & 1 deletion metadata-models/src/main/pegasus/com/linkedin/ml/metadata/EthicalConsiderations.pdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ record EthicalConsiderations {
data: optional array[string]

/**
* Is the MLModel intended to inform decisions about matters central to human life or flourishing – e.g., health or safety? Or could it be used in such a way?
* Is the MLModel intended to inform decisions about matters central to human life or flourishing - e.g., health or safety? Or could it be used in such a way?
*/
humanLife: optional array[string]

Expand Down
2 changes: 1 addition & 1 deletion metadata-models/src/main/pegasus/com/linkedin/ml/metadata/MLModelFactors.pdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ record MLModelFactors {

/**
* The performance of a MLModel can vary depending on what instruments were used to capture the input to the MLModel.
* For example, a face detection model may perform differently depending on the camera’s hardware and software,
* For example, a face detection model may perform differently depending on the camera's hardware and software,
* including lens, image stabilization, high dynamic range techniques, and background blurring for portrait mode.
*/
instrumentation: optional array[string]
Expand Down