feat(ui) Add new embedded profile to be displayed in extension #7113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…skeleton-and-header feat(ui) Build skeleton + header of new embedded profile
…t-section feat(ui) Update SidebarAboutSection and use in EmbeddedProfile
…sidebar-sections feat(ui) Make Owner, Tag, Term, Domain sections optionally readOnly
…ealth feat(ui) Add upstream health component to embedded profile
aditya-radhakrishnan
approved these changes
Jan 23, 2023
|
Seems that some build is failing :) |
|
Minor copy comments added offline |
jjoyce0510
reviewed
Jan 24, 2023
| pictureLink?: string; | ||
| } | ||
|
|
||
| export default function OwnerContent({ name, owner, hidePopOver, pictureLink }: Props) { |
jjoyce0510
reviewed
Jan 24, 2023
| {EMPTY_MESSAGES.documentation.title}. {EMPTY_MESSAGES.documentation.description} | ||
| </EmptyContentMessage> | ||
| {!readOnly && ( | ||
| <Button onClick={() => routeToTab({ tabName: 'Documentation', tabParams: { editing: true } })}> |
jjoyce0510
reviewed
Jan 24, 2023
| readOnly?: boolean; | ||
| } | ||
|
|
||
| export default function LinksSection({ hideLinksButton, readOnly }: Props) { |
There was a problem hiding this comment.
Is this just a file being moved?
There was a problem hiding this comment.
yup! just pulled it out from the old bigger SidebarAboutSection component.
jjoyce0510
reviewed
Jan 26, 2023
| link: InstitutionalMemoryMetadata; | ||
| } | ||
|
|
||
| export default function LinkButton({ link }: Props) { |
jjoyce0510
reviewed
Jan 26, 2023
| getOverrideProperties: (T) => GenericEntityProperties; | ||
| } | ||
|
|
||
| export default function useGetDataForProfile<T>({ urn, entityType, useEntityQuery, getOverrideProperties }: Props<T>) { |
jjoyce0510
reviewed
Jan 26, 2023
| </LoadingWrapper> | ||
| )} | ||
| {!loading && entityData && ( | ||
| <> |
There was a problem hiding this comment.
Look at this clean stack
jjoyce0510
reviewed
Jan 26, 2023
| }); | ||
| }; | ||
|
|
||
| const removeTerm = (termToRemove: GlossaryTermAssociation) => { |
There was a problem hiding this comment.
How one thing I think almost 100% we will face merge back issues due to proposals. Just calling out!
jjoyce0510
reviewed
Jan 26, 2023
| refetch?: () => Promise<any>; | ||
| } | ||
|
|
||
| export default function StyledTerm(props: Props) { |
jjoyce0510
reviewed
Jan 26, 2023
| }); | ||
| }; | ||
|
|
||
| return ( |
jjoyce0510
reviewed
Jan 26, 2023
| @@ -781,6 +781,17 @@ fragment searchAcrossRelationshipResults on SearchAcrossLineageResults { | |||
| searchResults { | |||
| entity { | |||
| ...searchResultFields | |||
| ... on Dataset { | |||
| assertions @include(if: $includeAssertions) { | |||
There was a problem hiding this comment.
Thanks for including this conditionally
There was a problem hiding this comment.
Pretty awesome that we can do this btw!
jjoyce0510
approved these changes
Jan 26, 2023
ericyomi
pushed a commit
to ericyomi/datahub
that referenced
this pull request
Feb 8, 2023
oleg-ruban
pushed a commit
to RChygir/datahub
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new EmbeddedProfile that will be displayed in an iFrame of our new chrome extension. This profile reuses lots of components from an entity profile sidebar and updates those components to allow them to be readOnly (this refactoring is the cause for a good chunk of the diff). This also creates a new
UpstreamHealthcomponent that fetches all upstreams and their assertions so that we can look through and see if anything is failing.When there are failing upstream assertions:
When there is at least one passing upstream assertion and none failing:
When there are no assertions upstream or no upstreams at all:
Checklist