Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui) Display glossary term name in analytics page properly #7128

Merged
merged 1 commit into from
Jan 25, 2023
Merged

fix(ui) Display glossary term name in analytics page properly #7128

merged 1 commit into from
Jan 25, 2023

Conversation

chriscollins3456
Copy link
Collaborator

Previously, we hydrated glossary term names based off the entity key name. Now that's just a UUID. We need to get the term name from the info aspect, but we can fall back on the key if the info aspect or the name on that aspect doesn't exist.

Before the fix:
image

After the fix:
image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jan 24, 2023
aditya-radhakrishnan
aditya-radhakrishnan approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this one!

@jjoyce0510 jjoyce0510 merged commit ea7b2ab into datahub-project:master Jan 25, 2023
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
@chriscollins3456
fix(ui) Display glossary term name in analytics page properly (datahu…
0f3662f 
…b-project#7128)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya-radhakrishnan aditya-radhakrishnan aditya-radhakrishnan approved these changes

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriscollins3456 @jjoyce0510 @aditya-radhakrishnan