feat(ui): allow removing parentNodes of Glossary Nodes and Glossary Terms #7135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...re/src/main/java/com/linkedin/datahub/graphql/resolvers/mutate/UpdateParentNodeResolver.java
Show resolved
Hide resolved
jjoyce0510
reviewed
Jan 26, 2023
| @@ -77,7 +82,12 @@ private Boolean updateGlossaryTermParentNode( | |||
| // If there is no info aspect for the term already, then we should throw since the model also requires a name. | |||
| throw new IllegalArgumentException("Info for this Glossary Term does not yet exist!"); | |||
| } | |||
| glossaryTermInfo.setParentNode(parentNodeUrn); | |||
|
|
|||
| if (parentNodeUrn != null) { | |||
jjoyce0510
reviewed
Jan 26, 2023
| @@ -7254,9 +7254,9 @@ Input for updating the parent node of a resource. Currently only GlossaryNodes a | |||
| """ | |||
| input UpdateParentNodeInput { | |||
| """ | |||
| The new parent node urn | |||
| The new parent node urn. If parentNode is null, this will remove the parent from this entity | |||
jjoyce0510
reviewed
Jan 26, 2023
| return CompletableFuture.supplyAsync(() -> { | ||
| Urn currentParentUrn = GlossaryUtils.getParentUrn(targetUrn, context, _entityClient); | ||
| // need to be able to manage current parent node and new parent node | ||
| if (GlossaryUtils.canManageChildrenEntities(context, currentParentUrn, _entityClient) | ||
| && GlossaryUtils.canManageChildrenEntities(context, parentNodeUrn, _entityClient)) { | ||
| && GlossaryUtils.canManageChildrenEntities(context, finalParentNodeUrn, _entityClient)) { |
There was a problem hiding this comment.
Is it okay that final Parent Node is null going into this method?
There was a problem hiding this comment.
Looks like the case is covered!
|
Will merge once CI is all green :) |
ericyomi
pushed a commit
to ericyomi/datahub
that referenced
this pull request
Feb 8, 2023
…erms (datahub-project#7135) Co-authored-by: John Joyce <[email protected]>
oleg-ruban
pushed a commit
to RChygir/datahub
that referenced
this pull request
Feb 28, 2023
…erms (datahub-project#7135) Co-authored-by: John Joyce <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UpdateParentNodeInputto use optionalparentNodefieldUpdateParentNodeResolverto accept emptyparentNodefieldparentNodeand postfix(Optional)text to the fieldChecklist