Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(oidc): Updating + improving docs around OIDC configuration #7141

Merged
merged 3 commits into from
Jan 26, 2023
Merged

docs(oidc): Updating + improving docs around OIDC configuration #7141

merged 3 commits into from
Jan 26, 2023

Conversation

jjoyce0510
Copy link
Collaborator

Summary

In this PR, we

  1. Fix outdated defaults specified in OIDC docs
  2. Add an FAQ section to address a very specific questions around OIDC.

Shout out to Adam Price in the community for helping drive this!

Status

Ready for review.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the docs Issues and Improvements to docs label Jan 25, 2023
aditya-radhakrishnan
aditya-radhakrishnan approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes!

@jjoyce0510 jjoyce0510 merged commit c74060f into datahub-project:master Jan 26, 2023
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
@jjoyce0510
docs(oidc): Updating + improving docs around OIDC configuration (data…
81b7419 
…hub-project#7141)
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@jjoyce0510
docs(oidc): Updating + improving docs around OIDC configuration (data…
2b453e6 
…hub-project#7141)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya-radhakrishnan aditya-radhakrishnan aditya-radhakrishnan approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjoyce0510 @aditya-radhakrishnan