fix(ui): Sort top users by their query count in datasets stats tab #7148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaykadambi
changed the title
|
Actually it looks like we are failing the frontend build. Can you please make sure the usage of useMemo is NOT conditional before we accept this? |
|
(You should not need to use useMemo at all) |
Will do this shortly. I wondered if I should in the first place. Let me remove it. |
@jjoyce0510 - removed useMemo. Please review and accept. Thanks! |
|
(Assuming you've tested this locally) Once we are green we will merge it in. Thanks! |
Yes. Looks green. Thanks! |
ericyomi
pushed a commit
to ericyomi/datahub
that referenced
this pull request
Feb 8, 2023
oleg-ruban
pushed a commit
to RChygir/datahub
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently the top users within the stats tab of a Dataset is not sorted by their query count. This change reflects the top users by their counts.
Example:
Sample usage statistics:
"aspectName" : "datasetUsageStatistics", "aspect" : { "value" : "{ \"timestampMillis\":1674749347000,\"partitionSpec\": {\"type\": \"FULL_TABLE\", \"partition\": \"FULL_TABLE_SNAPSHOT\"}, \"totalSqlQueries\": 155, \"uniqueUserCount\": 1, \"userCounts\": [{\"user\": \"urn:li:corpuser:datahub\", \"count\": 21, \"userEmail\": \"[email protected]\"},{\"user\": \"urn:li:corpuser:jkadambi\", \"count\": 100, \"userEmail\": \"[email protected]\"},{\"user\": \"urn:li:corpuser:eaipeas\", \"count\": 9920, \"userEmail\":\"[email protected]\"},{\"user\": \"urn:li:corpuser:jac_script\", \"count\": 35, \"userEmail\": \"[email protected]\"},{\"user\": \"urn:li:corpuser:dbrumba2\", \"count\": 2035, \"userEmail\": \"[email protected]\"}]}", "contentType": "application/json"Checklist