Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui): Updates to Manual Lineage search #7151

Merged
merged 2 commits into from
Jan 27, 2023
Merged

refactor(ui): Updates to Manual Lineage search #7151

merged 2 commits into from
Jan 27, 2023

Conversation

jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Jan 26, 2023 •
edited
Loading

Summary

In this PR we tune the experience of searching for entities within the Add entities modal, including:

  1. A loading indicator when search results are loading
  2. Remove select behavior that was filtering results unnecessarily
  3. Add no entities found indicator in case of no results.
  4. Auto-select the input box when modal opens

See screen capture below for demo.

Status

Ready for review.

Screen.Recording.2023-01-26.at.2.28.21.PM.mov

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jan 26, 2023
chriscollins3456
chriscollins3456 approved these changes Jan 27, 2023
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing. thank you!

@jjoyce0510 jjoyce0510 merged commit 590ef62 into datahub-project:master Jan 27, 2023
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
@jjoyce0510
refactor(ui): Updates to Manual Lineage search (datahub-project#7151)
24e3fc0
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@jjoyce0510
refactor(ui): Updates to Manual Lineage search (datahub-project#7151)
7a52067
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjoyce0510 @chriscollins3456