Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lineage): add time filtering for lineage edges #7159

Merged
merged 2 commits into from
Feb 2, 2023
Merged

feat(lineage): add time filtering for lineage edges #7159

merged 2 commits into from
Feb 2, 2023

Conversation

aditya-radhakrishnan
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan commented Jan 27, 2023 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests labels Jan 27, 2023
@aditya-radhakrishnan aditya-radhakrishnan force-pushed the ar--01-03-lineage-time-ui branch 2 times, most recently from 0bc9a50 to 29d51db Compare January 28, 2023 00:34
@jjoyce0510
Copy link
Collaborator

metadata-io failing build

@aditya-radhakrishnan aditya-radhakrishnan force-pushed the ar--01-03-lineage-time-ui branch 5 times, most recently from 4f9b77a to 429e0b6 Compare February 1, 2023 22:22
jjoyce0510
jjoyce0510 reviewed Feb 2, 2023
View reviewed changes
...data-jobs/mae-consumer/src/main/java/com/linkedin/metadata/kafka/hook/UpdateIndicesHook.java
private static List<Edge> getMergedEdges(final Set<Edge> oldEdgeSet, final Set<Edge> newEdgeSet) {
final Map<Integer, com.linkedin.metadata.graph.Edge> oldEdgesMap = oldEdgeSet
.stream()
.map(edge -> Pair.of(edge.hashCode(), edge))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could bite us later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like surround it with a try/catch?

Or wdym?

jjoyce0510
jjoyce0510 approved these changes Feb 2, 2023
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty rad change. Once we go green I think we're good to go. Given the size of this change, let's be very alert w.r.t. what we hear frm community

@aditya-radhakrishnan aditya-radhakrishnan merged commit c13e7e0 into datahub-project:master Feb 2, 2023
@aditya-radhakrishnan aditya-radhakrishnan deleted the ar--01-03-lineage-time-ui branch February 2, 2023 23:30
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
@aditya-radhakrishnan
feat(lineage): add time filtering for lineage edges (datahub-project#…
7997620 
…7159)
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@aditya-radhakrishnan
feat(lineage): add time filtering for lineage edges (datahub-project#…
0b006ec 
…7159)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

@chriscollins3456 chriscollins3456 Awaiting requested review from chriscollins3456

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aditya-radhakrishnan @jjoyce0510