Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a linter for github actions workflows #7178

Merged
merged 2 commits into from
Jan 30, 2023
Merged

feat: add a linter for github actions workflows #7178

merged 2 commits into from
Jan 30, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jan 30, 2023

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2 hsheth2 changed the title ci(ingest): fix broken CI workflow for metadata-ingestion feat: add a linter for github actions workflows Jan 30, 2023
@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Jan 30, 2023
@hsheth2 hsheth2 requested a review from anshbansal January 30, 2023 18:24
jjoyce0510
jjoyce0510 reviewed Jan 30, 2023
View reviewed changes
.github/workflows/docker-unified.yml
@@ -423,9 +399,6 @@ jobs:
name: Build and Push DataHub Elasticsearch Setup Docker Image
runs-on: ubuntu-latest
needs: setup
outputs:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just unnecessry? Not providing any value? Or are outputs from prev step just automatically propagated?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. These are unused, right?

jjoyce0510
jjoyce0510 reviewed Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the linter is failing :p

jjoyce0510
jjoyce0510 reviewed Jan 30, 2023
View reviewed changes
.github/workflows/docker-ingestion-smoke.yml
@@ -48,9 +48,6 @@ jobs:
name: Build and Push Docker Image to Docker Hub
runs-on: ubuntu-latest
needs: setup
outputs:
image_tag: ${{ steps.docker_meta.outputs.tags }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused output?

@hsheth2
Copy link
Collaborator Author

hsheth2 commented Jan 30, 2023

Lint issue will be fixed by #7179

@jjoyce0510 jjoyce0510 merged commit 7e869cd into datahub-project:master Jan 30, 2023
@hsheth2 hsheth2 deleted the ci-lint branch January 30, 2023 21:26
danielcmessias pushed a commit to danielcmessias/datahub that referenced this pull request Feb 1, 2023
@hsheth2 @jjoyce0510 @danielcmessias
feat(): add a linter for github actions workflows (datahub-project#7178)
b8ede07 
Co-authored-by: John Joyce <[email protected]>
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
@hsheth2 @jjoyce0510
feat(): add a linter for github actions workflows (datahub-project#7178)
9c4bf93 
Co-authored-by: John Joyce <[email protected]>
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@hsheth2 @jjoyce0510
feat(): add a linter for github actions workflows (datahub-project#7178)
7c2f39f 
Co-authored-by: John Joyce <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

@anshbansal anshbansal Awaiting requested review from anshbansal

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @jjoyce0510