fix(quickstart): adding back kafka-setup #7181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szalai1
changed the title
| @@ -1,15 +1,4 @@ | |||
| # Service definitions for Kafka Setup container. | |||
| # Empty docker compose for kafka-setup as we have moved kafka-setup back into the main compose | |||
There was a problem hiding this comment.
Can this just be removed? It's not defining any services
There was a problem hiding this comment.
The CLIs that were installed in the last couple of days will try to pull this file, this way they won't fail.
github-actions
bot
added
devops
RyanHolstien
approved these changes
Jan 30, 2023
danielcmessias
pushed a commit
to danielcmessias/datahub
that referenced
this pull request
Feb 1, 2023
Co-authored-by: Shirshanka Das <[email protected]>
ericyomi
pushed a commit
to ericyomi/datahub
that referenced
this pull request
Feb 8, 2023
Co-authored-by: Shirshanka Das <[email protected]>
oleg-ruban
pushed a commit
to RChygir/datahub
that referenced
this pull request
Feb 28, 2023
Co-authored-by: Shirshanka Das <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is change is fixing the failing quickstart for older versions.
Older versions are trying to pull the latest quickstart yaml from the repo (the one without kafka-setup), but since old CLI version waits for the
kafka-setupjob to finish, they were failing to start.Adding the job back (with a passthrough option) to avoid quickstart failures.
Checklist