feat(ui): Supporting display of columns and storage count in previews #7198
Conversation
github-actions
bot
added
ingestion
| const formatBytesStat = (bytes: number) => { | ||
| const formattedBytes = formatBytes(bytes); | ||
| return ( | ||
| <Tooltip title={`This dataset consumes ${formatNumberWithoutAbbreviation(bytes)} bytes of storage.`}> | ||
| <b>{formattedBytes.number}</b> {formattedBytes.unit} | ||
| </Tooltip> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
this is really more of a new component and not so much a helper function. so maybe we call this FormattedBytesStat that accepts bytes as a prop?
There was a problem hiding this comment.
yeah i like that!
datahub-web-react/src/app/entity/dataset/shared/DatasetStatsSummary.tsx
Outdated
Show resolved
Hide resolved
| )) || | ||
| undefined} |
There was a problem hiding this comment.
nitty nit: the || undefined here isn't necessary! if you do {!!columnCount && (... it will only render what comes next if !!columnCount is truthy
There was a problem hiding this comment.
awesome! will change
|
|
||
| const k = 1000; // We use IEEE standards definition of units of byte, where 1000 bytes = 1kb. | ||
| const dm = decimals < 0 ? 0 : decimals; | ||
| const sizes = ['Bytes', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB']; |
There was a problem hiding this comment.
lol at "ZB" and "YB" that's a lotta bytes
|
@jjoyce0510 seeing build failing with |
jjoyce0510
force-pushed
the
jj--add-storage-size-column-count-to-stats
branch
from
5af5846 to
a304f71
Compare
Summary
In this PR we introduce support for a) column count and b) storage size in bytes on the Dataset Stats Summary - this is shown both on the search card and on the entity profile.
Status
Ready for review
Screenshots
Checklist