Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): missing variables in test causing error in logs #7210

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

anshbansal
Copy link
Collaborator

This was causing exceptions in gms logs as follows

[ForkJoinPool.commonPool-worker-7] ERROR c.datahub.graphql.GraphQLController:100 - Errors while executing graphQL query: "\n            query getMetadataAnalyticsCharts($input: MetadataAnalyticsInput!) {\n                getMetadataAnalyticsCharts(input: $input) {\n                    groupId\n                    title\n                }\n            }\n        ", result: {errors=[{message=Variable 'input' has an invalid value: Variable 'input' has coerced Null value for NonNull type 'MetadataAnalyticsInput!', locations=[{line=2, column=46}], extensions={classification=ValidationError}}], data=null, extensions={tracing={version=1, startTime=2023-02-01T12:29:51.971957Z, endTime=2023-02-01T12:29:51.976488Z, duration=4550667, parsing={startOffset=1210959, duration=1064750}, validation={startOffset=2269709, duration=987709}, execution={resolvers=[]}}}}, errors: [graphql.execution.NonNullableValueCoercedAsNullException: Variable 'input' has an invalid value: Variable 'input' has coerced Null value for NonNull type 'MetadataAnalyticsInput!']

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the smoke_test Contains changes related to smoke tests label Feb 1, 2023
@anshbansal anshbansal changed the title fix(test): add test causing error in logs fix(test): missing variables in test causing error in logs Feb 1, 2023
@jjoyce0510 jjoyce0510 merged commit b8b2e48 into master Feb 1, 2023
@jjoyce0510 jjoyce0510 deleted the aseem-fix-read-only-test branch February 1, 2023 23:15
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke_test Contains changes related to smoke tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants