fix(gms): Fixes delete references for single relationship aspects #7211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #5992 |
RyanHolstien
requested changes
Feb 1, 2023
| if (!ingestProposalResult.isDidUpdate()) { | ||
| log.error("Failed to ingest aspect with references removed. Before {}, after: null, please check MCP processor" | ||
| RollbackResult rollbackResult = _entityService.deleteAspect(urn.toString(), aspectName, new HashMap<>(), true); | ||
| assert rollbackResult != null; |
There was a problem hiding this comment.
Assert statement should get wrapped into below conditional and proposal is no longer used except for the error message which is invalid as it's not being used.
There was a problem hiding this comment.
Good catch, please take another look.
RyanHolstien
approved these changes
Feb 1, 2023
jjoyce0510
reviewed
Feb 1, 2023
| @@ -403,6 +396,7 @@ private enum DeleteEntityServiceErrorReason { | |||
| ENTITY_SERVICE_ASPECT_NOT_FOUND, | |||
| ENTITY_REGISTRY_SPEC_NOT_FOUND, | |||
| MCP_PROCESSOR_FAILED, | |||
| ASPECT_DELETE_FAILED, | |||
jjoyce0510
reviewed
Feb 1, 2023
| import static org.testng.AssertJUnit.*; | ||
|
|
||
|
|
||
| public class DeleteEntityServiceTest { |
There was a problem hiding this comment.
scary if we did not have a class test for this previously :o
jjoyce0510
approved these changes
Feb 1, 2023
ericyomi
pushed a commit
to ericyomi/datahub
that referenced
this pull request
Feb 8, 2023
…tahub-project#7211) Deleting Container references were broken. This PR fixes that. Root cause is datahub-project#5248 which changed the MCP change type to DELETE for cases where an aspect after getting the reference removed was no longer valid. We do not support DELETE operations for MCPs. The solution is then to execute EntityService#deleteAspect rather than emit a sync MCP. A regression test was made to prevent this from happening again. Co-authored-by: John Joyce <[email protected]>
oleg-ruban
pushed a commit
to RChygir/datahub
that referenced
this pull request
Feb 28, 2023
…tahub-project#7211) Deleting Container references were broken. This PR fixes that. Root cause is datahub-project#5248 which changed the MCP change type to DELETE for cases where an aspect after getting the reference removed was no longer valid. We do not support DELETE operations for MCPs. The solution is then to execute EntityService#deleteAspect rather than emit a sync MCP. A regression test was made to prevent this from happening again. Co-authored-by: John Joyce <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting Container references were broken. This PR fixes that.
Root cause is #5248 which changed the MCP change type to DELETE for cases where an aspect after getting the reference removed was no longer valid. We do not support DELETE operations for MCPs.
The solution is then to execute EntityService#deleteAspect rather than emit a sync MCP.
A regression test was made to prevent this from happening again.
Checklist