Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(glue): Use table name as human-readable name for Glue ingestion #7213

Merged
merged 2 commits into from
Feb 2, 2023
Merged

feat(glue): Use table name as human-readable name for Glue ingestion #7213

merged 2 commits into from
Feb 2, 2023

Conversation

danielcmessias
Copy link
Contributor

@danielcmessias danielcmessias commented Feb 1, 2023 •
edited
Loading

(re-raised from #7190)

The FQN includes the catalog ID and database name. Add in the 'name' field that is just the table name, like the SQL-based sources, to make it more readable in the UI

Before:
Screenshot 2023-01-31 at 12 15 01

After:
Screenshot 2023-01-31 at 12 16 08

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@danielcmessias
feat(ingest/glue) Use table name as human-readable name for Glue inge…
136c34f 
…stion

The FQN includes the catalog ID and database name. Add in the 'name'
field that is just the table name, like the SQL-based sources, to
make it more readable in the UI
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Feb 1, 2023
@danielcmessias danielcmessias mentioned this pull request Feb 1, 2023
Closed
5 tasks
chriscollins3456
chriscollins3456 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! once we ensure CI is green and tests are passing this will be good to go

@danielcmessias
Copy link
Contributor Author

Thanks for looking @chriscollins3456! Looks like the tests are passing - scans are failing but not clear if I've done anything, I'm not sure how often you expect those checks to pass 😅

@anshbansal anshbansal added the community-contribution PR or Issue raised by member(s) of DataHub Community label Feb 2, 2023
treff7es
treff7es approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for the contribution!

@treff7es treff7es merged commit 0d67e18 into datahub-project:master Feb 2, 2023
@danielcmessias danielcmessias deleted the glue_ingestion_table_name_2 branch February 3, 2023 11:46
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
@danielcmessias @jjoyce0510
feat(glue): Use table name as human-readable name for Glue ingestion (d…
f2e0855 
…atahub-project#7213)

Co-authored-by: John Joyce <[email protected]>
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@danielcmessias @jjoyce0510
feat(glue): Use table name as human-readable name for Glue ingestion (d…
b5c7c3b 
…atahub-project#7213)

Co-authored-by: John Joyce <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danielcmessias @treff7es @chriscollins3456 @anshbansal @jjoyce0510