fix(ui) Increase the number of assertions that we query for in tab #7215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an issue raised that explains how we don't fetch all assertions in the Validations tab so the number displayed next to the entity name doesn't match what we show in the validations tab.
The quick fix here is to increase the hardcoded number from 100 -> 1000 assertions we get. This query is run only in the validations tab so it won't increase the latency of dataset page load overall.
The better solution, in my opinion, is to keep total as 100 but add pagination to the tab. We would need to change how we generate the summary to show how many are passing out of the total on that page as well. This isn't a huge lift, but bigger than I was willing to commit at the moment, so I created a Linear ticket for it and made this quick fix to solve the immediate problem for peope.
Checklist