Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev.sh): Add context to kafka-setup build #7234

Merged
merged 5 commits into from
Feb 3, 2023
Merged

fix(dev.sh): Add context to kafka-setup build #7234

merged 5 commits into from
Feb 3, 2023

Conversation

szalai1
Copy link
Contributor

@szalai1 szalai1 commented Feb 2, 2023

Build context didn't point to the right directory (root), thus the Dockerfile referenced the wrong files

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@szalai1
fix(dev.sh): Add context to kafka-setup build
e9a18a2 
Build context didn't point to the right directory (root), thus the Dockerfile referenced the wrong files
@szalai1
Merge branch 'master' into kafka-setup-build
3e90c37
jjoyce0510
jjoyce0510 approved these changes Feb 2, 2023
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Feb 2, 2023
@anshbansal anshbansal merged commit 0a43d25 into datahub-project:master Feb 3, 2023
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
@szalai1
fix(dev.sh): Add context to kafka-setup build (datahub-project#7234)
c7f36cd
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@szalai1
fix(dev.sh): Add context to kafka-setup build (datahub-project#7234)
a553792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

@RyanHolstien RyanHolstien RyanHolstien approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@szalai1 @RyanHolstien @jjoyce0510 @anshbansal