docs(graphql): remove reference of non-existent gms.graphql #7240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshbansal
reviewed
Feb 3, 2023
| @@ -8,7 +8,7 @@ permitting reads and writes against the entities and aspects on the Metadata Gra | |||
|
|
|||
| Contained within this module are | |||
|
|
|||
| 1. **GMS Schema**: A GQL schema that based on GMS models, located under `resources/gms.graphql`. | |||
There was a problem hiding this comment.
There is no folder datahub-graphql-core/resources/ either. So what is this new location pointing to?
There was a problem hiding this comment.
src/main/resources
There was a problem hiding this comment.
This doc will go into public docs website. So we will need a URL that people looking at public docs can understand.
There was a problem hiding this comment.
updated to add link.
mayurinehate
force-pushed
the
graphql_doc_update
branch
from
060af29 to
f62bdce
Compare
anshbansal
approved these changes
Feb 6, 2023
ericyomi
pushed a commit
to ericyomi/datahub
that referenced
this pull request
Feb 8, 2023
oleg-ruban
pushed a commit
to RChygir/datahub
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reported in this slack thread - https://datahubspace.slack.com/archives/C029A3M079U/p1675416618086009
Checklist