Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(change-events): guard against NPE's #7264

Merged
merged 1 commit into from
Feb 7, 2023
Merged

fix(change-events): guard against NPE's #7264

merged 1 commit into from
Feb 7, 2023

Conversation

aditya-radhakrishnan
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan commented Feb 6, 2023 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Feb 6, 2023
jjoyce0510
jjoyce0510 reviewed Feb 7, 2023
View reviewed changes
...n/java/com/linkedin/metadata/timeline/eventgenerator/SchemaMetadataChangeEventGenerator.java
parentUrn = UrnUtils.getUrn(parentUrnStr);
} catch (Exception e) {
log.error("Failed to parse parentUrnStr: {}", parentUrnStr, e);
return Collections.emptyList();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

jjoyce0510
jjoyce0510 approved these changes Feb 7, 2023
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM once passing. Thanks!

@aditya-radhakrishnan aditya-radhakrishnan merged commit 3a8fd69 into datahub-project:master Feb 7, 2023
@aditya-radhakrishnan aditya-radhakrishnan deleted the ar--02-06-null-change-events branch February 7, 2023 00:38
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
@aditya-radhakrishnan
fix(change-events): guard against NPE's (datahub-project#7264)
a74dacd
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@aditya-radhakrishnan
fix(change-events): guard against NPE's (datahub-project#7264)
3aded02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aditya-radhakrishnan @jjoyce0510