Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/metabase): Allow to configure a different url for links #9727

Merged
merged 1 commit into from
Feb 5, 2024
Merged

feat(ingest/metabase): Allow to configure a different url for links #9727

merged 1 commit into from
Feb 5, 2024

Conversation

ilpianista
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Jan 26, 2024
@ilpianista
Copy link
Contributor Author

@hsheth2 any chance you may have a look at this? 🙏

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Feb 2, 2024
@anshbansal anshbansal merged commit f743d3c into datahub-project:master Feb 5, 2024
53 checks passed
@ilpianista ilpianista deleted the feature/metabase-ingestion-display_uri branch February 5, 2024 12:52
@diegmonti diegmonti mentioned this pull request Mar 6, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilpianista @hsheth2 @anshbansal