Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search): search access controls unit tests #9925

Merged
merged 1 commit into from
Feb 27, 2024
Merged

feat(search): search access controls unit tests #9925

merged 1 commit into from
Feb 27, 2024

Conversation

david-leifker
Copy link
Collaborator

@david-leifker david-leifker commented Feb 26, 2024 •
edited
Loading

Adds unit tests with a few quality of life fixes around constructors, lists v. sets for repeatable tests, and constants.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Feb 26, 2024
@david-leifker david-leifker merged commit a8e3c6d into search-access-controls Feb 27, 2024
43 checks passed
@david-leifker david-leifker deleted the search-access-controls-unit-tests branch February 27, 2024 15:10
david-leifker added a commit that referenced this pull request Feb 28, 2024
@david-leifker
feat(search): search access controls unit tests (#9925)
c47db24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-leifker @RyanHolstien