Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms) Fix a couple of small inconsistencies with forms #9928

Conversation

chriscollins3456
Copy link
Collaborator

While doing other forms work, I came across a couple of small inconsistencies with out forms work that should have been included in the original PR that brought forms into open source.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Feb 27, 2024
@samblackk
Copy link
Contributor

@chriscollins3456 Seems that Docker Build, Scan, Test / Run Smoke Tests (cypress_rest) (pull_request) is failing. Something we need to address here?

@samblackk samblackk added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Mar 22, 2024
@chriscollins3456
Copy link
Collaborator Author

@chriscollins3456 Seems that Docker Build, Scan, Test / Run Smoke Tests (cypress_rest) (pull_request) is failing. Something we need to address here?

nope looks totally unrelated and in fact known flaky tests! i'm merging master into this branch one more time since it's an old PR then i'll merge once green

@chriscollins3456 chriscollins3456 merged commit c8a3818 into datahub-project:master Mar 25, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-pending-ci A PR that has passed review and should be merged once CI is green. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants