-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major changes and updates to facemapSVD pipeline #38
Major changes and updates to facemapSVD pipeline #38
Conversation
ttngu207
commented
Aug 20, 2024
- Rename SVD component-related table attributes
- Update ingestion to handle FullSVD analysis
- Remove redundant helper functions
|
||
_, creation_time = get_loader_result(key, FacemapTask) | ||
key = {**key, "processing_time": creation_time} | ||
run_facemap_process() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to make the function private and rename it to _run_facemap_process()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An example here, _run_sorter()
in element-array-ephys
.
setup.py
Outdated
"opencv-python", | ||
"element-interface @ git+https://github.com/datajoint/element-interface.git", | ||
"facemap @ git+https://github.com/kushalbakshi/facemap.git", | ||
"facemap[gui] @ git+https://github.com/datajoint/facemap.git", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following other elements, such as element-deeplabcut
setup, I would move the installation of the GUI to extras_require
and make it optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. If you could update the run_facemap_process
function based on Milagros' comment above, it will ensure consistency in how we deploy the memoized_result
functionality across Elements. Otherwise, this is ready to merge.
@MilagrosMarin @kushalbakshi new commit added to address your comment. |
Yes, it's probably a good idea to update that one too. As a general rule, any function within the make should probably follow the private function convention just to discourage its use outside the |