Fixes for GDHF demo #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n as column tests
…and entity_id instead of entity name (which can be ambiguous. GE is a mess, way overly complicated. Will raise backlog items to make this a lot simpler
…and entity_id instead of entity name (which can be ambiguous. GE is a mess, way overly complicated. Will raise backlog items to make this a lot simpler
…o a point where both riders and airline data run all tests successfully except for "expect_similar_means_across_all_reporters". In these cases, entity_id is set to "dot_modell__..." instead of the correct uuid. The cases should be caught in the get_test_rows function but apparently still slip through (if statement not executed at all). Further investigation needed
…le_dot_data.sql to include the correct entity ID, adjusted utils.py function get_entity_name_from_id to convert the uuid into string so the query returns the correct result
|
Converted to individual PRs |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will not be merged, instead all the fixes here will be split into their own PRs