Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems sometimes column can be null, resulting in schema tests going i… #67

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Seems sometimes column can be null, resulting in schema tests going i… #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dot/utils/configuration_management.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,10 +339,10 @@ def generate_tests_from_db(project_id, logger=logging.Logger):
# test_parameters = ""

# Update 'tests' node for this entity with non column-specific tests
if column_name in (None, ""):
if column_name in (None, "","null"):
if "tests" not in config_options[entity_id]:
config_options[entity_id]["tests"] = []
if test_parameters not in ("", None):
if test_parameters not in ("", None,"null"):
test = {test_type: test_parameters}
config_options[entity_id]["tests"].append(test)

Expand Down