Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Recipe Management #32

Merged
merged 42 commits into from
Jun 1, 2024
Merged

Adding Recipe Management #32

merged 42 commits into from
Jun 1, 2024

Conversation

JanPeterDatakind
Copy link
Contributor

Recipe Managers can now check out recipes from the db into a docker container, connect the container to their IDE, run, debug, and edit the recipe code, update other information about the record such as the intent, then check them back into the database.

@JanPeterDatakind JanPeterDatakind requested a review from dividor May 16, 2024 22:07
@dividor
Copy link
Contributor

dividor commented May 28, 2024

Hi @JanPeterDatakind,

I started running locally, great stuff!

I checked in a change to merge recipes-creation into recipes-management, one less container. I also removed the VS Code container as a requirement, instead instructing that the user can exec into a the management container, or simply run with: docker exec haa-recipe-manager python recipe_sync.py --check_out <YOUR NAME>. More advanced users can configure remote containers, but I felt this was more consistent for now and reduced complexity a little.

A few feedback items on the PR as follows:

  1. Let's import skills.py from the parent rather than copy into each recipe

  2. Please fix the bug that creates multiple main calls on checking in/out

  3. Remove any code which calculates embeddings and the python modules needed for that. See memory.py for examples

  4. Fix failed code checks in Github actions (ensure pre-commit hooks are active)

  5. Let's remove legacy recipes in the demo data and only have recipes using new format

  6. Add two line breaks after boiler-plate code to import modules, and recipes code. Easier to read

@dividor
Copy link
Contributor

dividor commented Jun 1, 2024

Thanks for responding to the requested feedback items @JanPeterDatakind. I will now merge this PR, noting that additional work around simplifying user experience for creating recipes will be tracked under a new PR.

@dividor dividor merged commit 14c00cd into main Jun 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants