Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct mode testing from travis and make crawler depend on non-rc versions of datalad/scrapy #40

Merged
merged 2 commits into from
Mar 12, 2019

Conversation

yarikoptic
Copy link
Member

See pypa/pip#4969 for IMHO weird behavior of pip in how to treat rcs specified as depends. Installing the released datalad should also resolve pyliblzma not being installed for python2 for now which was manifested in #29. Correct fix in datalad was submitted: datalad/datalad#3220

@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #40 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   86.36%   86.34%   -0.02%     
==========================================
  Files          51       51              
  Lines        4173     4175       +2     
==========================================
+ Hits         3604     3605       +1     
- Misses        569      570       +1
Impacted Files Coverage Δ
datalad_crawler/pipelines/openfmri.py 85% <0%> (-1.45%) ⬇️
datalad_crawler/nodes/tests/test_misc.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 067aa48...9cc1294. Read the comment docs.

@yarikoptic yarikoptic merged commit af67967 into datalad:master Mar 12, 2019
@yarikoptic yarikoptic deleted the bf-no-direct branch March 14, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant