Remove print statement added in recent commit #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
=== Do not change lines below ===
{
"chain": [],
"cmd": "git show 0892fa7 -- datalad_metalad/extract.py | patch -p1 -R",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
yarikoptic
commented
Jan 23, 2024
| @@ -798,8 +798,6 @@ def legacy_get_file_info(dataset: Dataset, | |||
|
|
|||
| def legacy_extract_file(ea: ExtractionArguments) -> Iterable[dict]: | |||
|
|
|||
| import sys | |||
| print(repr(ea), file=sys.stderr) | |||
There was a problem hiding this comment.
if to be printed -- should be logged IMHO
There was a problem hiding this comment.
Thanks, that was left in by mistake
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## maint_0.4 #409 +/- ##
=============================================
- Coverage 83.05% 83.04% -0.01%
=============================================
Files 92 92
Lines 5027 5025 -2
=============================================
- Hits 4175 4173 -2
Misses 852 852 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.