Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no update tests on windows #61

Open
bpoldrack opened this issue Jan 25, 2021 · 0 comments
Open

no update tests on windows #61

bpoldrack opened this issue Jan 25, 2021 · 0 comments

Comments

@bpoldrack
Copy link
Member

While enabling windows tests in PR #59, tests for update where skipped. This is because they rely on a drop-in replacement for ukbfetch defined in test_update.py. The drop in currently is a shebang script that probably(?) doesn't work on windows. In addition the respective change to PATH hardcodes : as separator - I think this needs to become ; on windows.
bpoldrack added a commit that referenced this issue Jan 25, 2021
@bpoldrack
TST: Skip update tests on windows
e826e0f 
Tests for update require adjustment of the drop-in replacement for
`ukbfetch`. See gh-61.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bpoldrack