Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive prompts #64

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Interactive prompts #64

wants to merge 2 commits into from

Conversation

adswa
Copy link
Member

@adswa adswa commented Sep 29, 2021

Here is a very quick and dirty implementation of interactive prompts. I think I will try to intergrate further developments of this in conjunction with a query command. See the comment with the GIF below to see how this feature behaves.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thx!

Can we get away without having a flag for interactive UI?

I.e.

from datalad.ui import ui
if ui.is_interactive:
    ....

@adswa
Copy link
Member Author

adswa commented Sep 30, 2021

Will do! However, I will delay working on this a bit until a query command has been introduced - maybe the need for interactive prompts doesn't exist anymore with the new command or api change

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2021

Codecov Report

Merging #64 (c6095da) into master (61f760b) will decrease coverage by 2.62%.
The diff coverage is 2.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   82.33%   79.71%   -2.63%     
==========================================
  Files          10       11       +1     
  Lines         334      419      +85     
==========================================
+ Hits          275      334      +59     
- Misses         59       85      +26     
Impacted Files Coverage Δ
datalad_xnat/init.py 70.00% <0.00%> (-2.59%) ⬇️
datalad_xnat/update.py 73.07% <3.12%> (-12.00%) ⬇️
datalad_xnat/tests/test_init.py 100.00% <0.00%> (ø)
datalad_xnat/parser.py 88.88% <0.00%> (+1.93%) ⬆️
datalad_xnat/platform.py 79.78% <0.00%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f760b...c6095da. Read the comment docs.

@adswa
Copy link
Member Author

adswa commented Sep 30, 2021

Here's an updated Gif of how this feature looks like:

interactive

@adswa adswa requested a review from mih September 30, 2021 09:04
@adswa
Copy link
Member Author

adswa commented Sep 30, 2021

shall I port this into the current state of the code?

@mih
Copy link
Member

mih commented Mar 2, 2022

I am putting this PR in draft mode for now. It would need to be revived and conflicts removed.

Also pinging datalad/datalad#396 where this could be an awesome way to select to-be-edited items.

@mih mih marked this pull request as draft March 2, 2022 11:39
mih pushed a commit that referenced this pull request Sep 25, 2023
Ci bumps: newer git annex and also python 3.8 not 3.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants